ui: Move the Role remove dialog to use InformedAction #11298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/472458. |
|
🍒✅ Cherry pick of commit 79b53ab onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Oct 14, 2021
|
🍒✅ Cherry pick of commit 79b53ab onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #11297 this fix is a lot better 😄 has main as the base branch, and will be backported to 1.9 (but not 1.8).
Thanks to @vinayak03's work in #11260 I spotted a little visual issue in the Token Form > Role Listing confirmation dialog.
Before:
This dialog still used our super old confirmation dialog instead of our InformedAction component, so the fix here is just upgrading the actions here to use the InformedAction component.
After:
Related #11297