-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
agent/token: rename agent_master
to agent_recovery
(internally)
#11744
Conversation
agent_master
to agent_recovery
agent_master
to agent_recovery
(internally)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Nice handling of the existing persisted agent tokens!
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/519650. |
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/521337. |
🍒✅ Cherry pick of commit 3a91815 onto |
Following the external-facing renaming of the
agent_master
ACL token toagent_recovery
(in #11665 and #11669) this PR is the first of a series to fix internal references to the old name, starting with theagent/token
package.It's worth noting that this changes the name of the field in the on-disk token persistence file (see: a876f52) but maintains support for reading files created by earlier versions of Consul, with the previous name.