Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDS snapshot updates are not correctly delivered after a first retry when certain conditions are met. #11923

Closed
dhiaayachi opened this issue Dec 29, 2021 · 0 comments · Fixed by #11924
Labels
theme/envoy/xds Related to Envoy support type/bug Feature does not function as expected

Comments

@dhiaayachi
Copy link
Collaborator

Overview of the Issue

This is sequel to #9689.

When an XDS snapshot is received and we set a timer to update after a coalesceTimer in here, if the 1st condition from #9689 is met and we end up in the default case of the select in here the coalesceTimer is never reset and snapshot updates end up never triggered again until the service is recreated because coalesceTimer will never be nil and would prevent sendCh from ever be signaled.

This issue would happen more frequently in overloaded systems, with a high number of services and a high number of XDS updates which will more likely trigger the 1st condition from #9689.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support type/bug Feature does not function as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants