ui: Alias all our Structure Icons to Flight Icons #12209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly missing brand icons
|
Quick note, just pushed a commit to move the aliased icons use the thicker-lined 16px icons. The change is basically this https://github.com/johncowen/iris/commit/adc72741a650183cf43770ef28ccb764d64e7f8a followed by a re-build/re-publish. |
amyrlam
suggested changes
Feb 1, 2022
|
Note: I have not done an exhaustive QA of the UI. |
* Remove hack for the inconsistent sort icon * Add a dark/light conditional switch and move to rem sizing for icons * Add a bunch of new themed semantic placeholders for some icons * Use those new placeholders where they are needed
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/572992. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our
styles/basewith the output fromiris, so just machine generated code.User facing change is: We are now using
@hashicorp/flight-icons🎉Preview Link
Small note: There are a few icons where the sizing or padding or something has changed, for example:
I'm going to look at these an PR separately ontop of here and potentially merge those onto here, but I'd be perfectly happy for this PR to go in before those little fixups and for the whatever work is involved in fixing up those odd icons to go in after. As always, I'm easy.
cc @didoo just an FYI that we are doing this now.