mark disable_compat_1.9 to deprecate in 1.13, change default to true #12675
Conversation
Signed-off-by: FFMMM <[email protected]>
github-actions
bot
added
theme/config
|
🤔 This PR has changes in the |
Signed-off-by: FFMMM <[email protected]>
|
You should add a point about the upgrade backwards incompatibility here: https://www.consul.io/docs/upgrading/upgrade-specific |
Co-authored-by: R.B. Boyer <[email protected]>
Signed-off-by: FFMMM <[email protected]>
…o ffmmm/no-19-metrics
agent/metrics_test.go
Outdated
| assertMetricNotExists(t, respRec, "agent_http_http_GET_v1_agent_members") | ||
| }) | ||
|
|
||
| t.Run("check that we cam still turn on consul.http metrics", func(t *testing.T) { |
| @@ -2175,7 +2175,7 @@ There are also a number of common configuration options supported by all provide | |||
| geo location or datacenter, dc:sfo). By default, this is left blank and not used. | |||
|
|
|||
| - `disable_compat_1.9` ((#telemetry-disable_compat_1.9)) | |||
| This allows users to disable metrics deprecated in 1.9 so they are no longer emitted, saving on performance and storage in large deployments. Defaults to false. | |||
| This allows users to disable metrics deprecated in 1.9 so they are no longer emitted, saving on performance and storage in large deployments. As of 1.12 this defaults to `true` and will be removed, along with 1.9 style http metrics in 1.13. | |||
There was a problem hiding this comment.
'saving on performance' is odd, maybe improving performance and reducing storage?
There was a problem hiding this comment.
That sounds good! That sentence was there before me but I can try to reword it.
|
all running into GH >< circle reporting issues again; PR approved beforehand, merging in! |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/621636. |
overview
I've been sitting on this patch for a bit. IIUC, the rationale was to remove 1.9 style
consul.http...metrics once 1.9 stopped being supported. But I don't think we can do that "smoothly" for 1.12 just yet.Instead of completely getting rid of them and throwing anyone that still instruments over these metrics into a panic, this PR suggests modifying the behavior of
disable_compat_1.9flag to default totrue. Yes, folks will still need to update their config but at least the metrics will still exist until 1.13 to give time to use the newconsul.api.http...introduced in 1.10.todo:
Signed-off-by: FFMMM [email protected]