Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change action to pull v1 instead of main #12846

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Conversation

claire-labry
Copy link
Collaborator

@claire-labry claire-labry commented Apr 22, 2022

The generate-metadata action needs to be pulling from tags for better release management. We run the risk of disruption if we pushed changes to the main branch of the generate-metadata action thus disrupting release workflows for Consul.

Read more on Using tags for release management

I added the backport labels for this PR, but I'm unsure which release branches Consul is using, so feel free to adjust!

@github-actions github-actions bot added the theme/contributing Additions and enhancements to community contributing materials label Apr 22, 2022
@eculver
Copy link
Contributor

eculver commented Apr 22, 2022

Those backport labels are correct. Could we add a ci: change action to pull v1 instead of main changelog entry too?

Copy link
Contributor

@eculver eculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd add a changelog entry as I mentioned in my other comment.

@claire-labry claire-labry merged commit 725d573 into main Apr 22, 2022
@claire-labry claire-labry deleted the update-metadata-action branch April 22, 2022 17:18
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/649697.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 725d573 onto release/1.12.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Apr 22, 2022
change action to pull v1 instead of main
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 725d573 onto release/1.11.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Apr 22, 2022
change action to pull v1 instead of main
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 725d573 onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Apr 22, 2022
change action to pull v1 instead of main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/contributing Additions and enhancements to community contributing materials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants