-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change action to pull v1 instead of main #12846
Conversation
Those backport labels are correct. Could we add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd add a changelog entry as I mentioned in my other comment.
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/649697. |
🍒✅ Cherry pick of commit 725d573 onto |
change action to pull v1 instead of main
🍒✅ Cherry pick of commit 725d573 onto |
change action to pull v1 instead of main
🍒✅ Cherry pick of commit 725d573 onto |
change action to pull v1 instead of main
The
generate-metadata
action needs to be pulling from tags for better release management. We run the risk of disruption if we pushed changes to themain
branch of the generate-metadata action thus disrupting release workflows for Consul.Read more on Using tags for release management
I added the backport labels for this PR, but I'm unsure which release branches Consul is using, so feel free to adjust!