feat(telemetry): add labels to serf and memberlist metrics #14161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr/dependencies
huikang
force-pushed
the
add-label-serf-metrics
branch
from
c880cc0 to
aab848a
Compare
rboyer
reviewed
Aug 11, 2022
rboyer
approved these changes
Aug 11, 2022
Co-authored-by: R.B. Boyer <[email protected]>
This was referenced Aug 12, 2022
Merged
Merged
3 tasks
3 tasks
davide-baldo
pushed a commit
to davide-baldo/consul
that referenced
this pull request
Aug 16, 2022
…#14161) (hashicorp#14170) * feat(telemetry): add labels to serf and memberlist metrics * changelog * doc update Co-authored-by: R.B. Boyer <[email protected]>
agrahamlincoln
pushed a commit
to vlognow/consul
that referenced
this pull request
Jan 6, 2023
…#14161) (hashicorp#14171) * feat(telemetry): add labels to serf and memberlist metrics * changelog * doc update Co-authored-by: R.B. Boyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To help user measure the gossip stability in the cluster, we need to separate the measurements between segment or partitions (for Enterprise). This PR adds the label to the serf metrics.
For OSS, we only label lan and wan network
consul_memberlist_gossip_count{job="client-1", network="lan", partition="team1"} | 72
consul_memberlist_gossip_count{job="server-1", network="lan", partition="default"} | 217
Links
Asana ticket
PR Checklist