Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSS] feat: add PeerThroughMeshGateways to mesh config #14475

Merged
merged 1 commit into from
Sep 13, 2022
Merged

[OSS] feat: add PeerThroughMeshGateways to mesh config #14475

merged 1 commit into from
Sep 13, 2022

Conversation

DanStough
Copy link
Contributor

Description

In anticipation of adding mesh gateway support for peering control-plane traffic, this PR adds a new field to the mesh config entry that will be used to enable the feature.

Testing & Reproduction steps

  • Unit tests included

Links

Kube CRD PR [TBD]

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

@DanStough DanStough added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test labels Sep 2, 2022
@DanStough DanStough requested a review from a team September 2, 2022 20:53
@DanStough DanStough requested a review from a team as a code owner September 2, 2022 20:53
@github-actions github-actions bot added theme/api Relating to the HTTP API interface type/docs Documentation needs to be created/updated/clarified labels Sep 2, 2022
@DanStough DanStough changed the title feat: add PeerThroughMeshGateways to mesh config [OSS] feat: add PeerThroughMeshGateways to mesh config Sep 2, 2022
@DanStough DanStough mentioned this pull request Sep 2, 2022
Merged
2 tasks
trujillo-adam
trujillo-adam reviewed Sep 6, 2022
View reviewed changes
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion to improve the introduction to the example. The code blocks aren't rendering correctly in the preview, possibly due to the indentations of the tab elements.

website/content/docs/connect/config-entries/mesh.mdx Outdated Show resolved Hide resolved
@DanStough DanStough force-pushed the dans/NET-645/mesh-entry-updates branch from d4da9f6 to ffc5815 Compare September 6, 2022 19:03
@DanStough
Copy link
Contributor Author

Thanks @trujillo-adam, I think I got the code blocks fixed now.

trujillo-adam
trujillo-adam reviewed Sep 9, 2022
View reviewed changes
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion

website/content/docs/connect/config-entries/mesh.mdx Outdated Show resolved Hide resolved
trujillo-adam
trujillo-adam reviewed Sep 13, 2022
View reviewed changes
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor tweaks for compliance with the style guide

website/content/docs/connect/config-entries/mesh.mdx Outdated Show resolved Hide resolved
trujillo-adam
trujillo-adam approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@trujillo-adam trujillo-adam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DanStough DanStough force-pushed the dans/NET-645/mesh-entry-updates branch from a5cb1d4 to 6391a87 Compare September 13, 2022 20:56
@DanStough DanStough merged commit 0150e88 into main Sep 13, 2022
@DanStough DanStough deleted the dans/NET-645/mesh-entry-updates branch September 13, 2022 21:19
@freddygv freddygv mentioned this pull request Sep 21, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddygv freddygv freddygv approved these changes

@trujillo-adam trujillo-adam trujillo-adam approved these changes

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test theme/api Relating to the HTTP API interface type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanStough @freddygv @trujillo-adam