Reuse http.DefaultTransport in UIMetricsProxy #14521
Merged
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 8, 2022 09:43
http.Transport keeps a pool of connections and should be reused when possible. We instantiate a new http.DefaultTransport for every metrics request, making large numbers of concurrent requests inefficiently spin up new connections instead of reusing open ones.
kisunji
commented
Sep 8, 2022
| @@ -771,6 +771,7 @@ func (s *HTTPHandlers) UIMetricsProxy(resp http.ResponseWriter, req *http.Reques | |||
| Director: func(r *http.Request) { | |||
| r.URL = u | |||
| }, | |||
| Transport: s.proxyTransport, | |||
There was a problem hiding this comment.
If nil, Transport defaults to http.DefaultTransport:
https://github.com/golang/go/blob/go1.19.1/src/net/http/httputil/reverseproxy.go#L52-L54
kisunji
requested review from
a team and
DanStough
and removed request for
a team
DanStough
approved these changes
Sep 8, 2022
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http.Transportkeeps a pool of connections and should be reused when possible. We instantiate a newhttp.DefaultTransportfor every metrics request, making large numbers of concurrent requests inefficiently spin up new connections instead of reusing open ones. This PR setshttp.DefaultTransportonce and re-uses it per request to generate the reverse proxy.Testing & Reproduction steps
PR Checklist