-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Stale Queries for Trust Bundle Lookups #14724
Support Stale Queries for Trust Bundle Lookups #14724
Conversation
agent/grpc-external/options_test.go
Outdated
func TestQueryOptionsFromContextRoundTrip(t *testing.T) { | ||
|
||
expected := structs.QueryOptions{ | ||
Token: "123", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you test all the fields on QueryOptions
. I think QueryOptionsFromContext
might result in errors when non-string fields are set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thanks! I updated the decode logic.
Description
Support Stale Queries for Trust Bundle Lookups
Testing & Reproduction steps
PR Checklist