Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Stale Queries for Trust Bundle Lookups #14724

Conversation

malizz
Copy link
Contributor

@malizz malizz commented Sep 22, 2022

Description

Support Stale Queries for Trust Bundle Lookups

Testing & Reproduction steps

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

@malizz malizz requested a review from freddygv September 22, 2022 22:47
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Sep 22, 2022
@malizz malizz changed the title initial commit Support Stale Queries for Trust Bundle Lookups Sep 23, 2022
@malizz malizz marked this pull request as ready for review September 26, 2022 21:44
func TestQueryOptionsFromContextRoundTrip(t *testing.T) {

expected := structs.QueryOptions{
Token: "123",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you test all the fields on QueryOptions. I think QueryOptionsFromContext might result in errors when non-string fields are set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks! I updated the decode logic.

@malizz malizz merged commit 84b0f40 into main Sep 28, 2022
@malizz malizz deleted the malizz/NET-650/support-stale-queries-for-peering-trust-bundle-lookups branch September 28, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants