Update go version to 1.19 #15090
Merged
Update go version to 1.19 #15090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr/dependencies
kisunji
added
the
pr/no-changelog
DanStough
previously requested changes
Oct 21, 2022
There was a problem hiding this comment.
I was taking a look at https://github.com/hashicorp/consul/pull/12808/files for reference, and I see a few more places to change:
- .github/workflows/build.yaml
- build-support/docker/Build-Go.dockerfile
- (new) test/integration/consul-container/go.mod
TBH I'm not really sure if we do changelogs for these changes, so maybe it's not necessary
Thanks for catching these! I grepped for 1.18 but those didn't come up for some reason 🤔 |
kisunji
force-pushed
the
kisunji/go1.19
branch
from
e3696c9 to
fa5f665
Compare
kisunji
requested review from
smacfarlane and
jeanneryan
and removed request for
a team
|
We typically do include changelog details as its helpful to know when go was updated https://github.com/hashicorp/consul/blob/main/CHANGELOG.md#1120-april-20-2022 |
kisunji
removed
the
pr/no-changelog
kisunji
force-pushed
the
kisunji/go1.19
branch
from
c555f06 to
aa76dff
Compare
|
1.19 formatting 😭 |
kisunji
force-pushed
the
kisunji/go1.19
branch
3 times, most recently
from
e78711a to
6d6ceaf
Compare
kisunji
force-pushed
the
kisunji/go1.19
branch
2 times, most recently
from
467c945 to
90fe897
Compare
kisunji
commented
Oct 24, 2022
| @@ -6,5 +6,5 @@ export GIT_DIRTY=$(test -n "`git status --porcelain`" && echo "+CHANGES" || true | |||
| export GIT_IMPORT=github.com/hashicorp/consul/version | |||
| # we're using this for build date because it's stable across platform builds | |||
| # the env -i and -noprofile are used to ensure we don't try to recursively call this profile when starting bash | |||
| export GIT_DATE=$(env -i /bin/bash --noprofile -norc ${CIRCLE_WORKING_DIRECTORY}/build-support/scripts/build-date.sh) | |||
There was a problem hiding this comment.
this was not expanding correctly: https://discuss.circleci.com/t/circle-working-directory-doesnt-expand/17007
this caused all CI runs to output:
~/project/build-support/scripts/build-date.sh: No such file or directory
90fe897 to
001fcd4
Compare
added 2 commits
October 24, 2022 13:04
kisunji
force-pushed
the
kisunji/go1.19
branch
2 times, most recently
from
e6abf2f to
f107d29
Compare
rboyer
reviewed
Oct 24, 2022
rboyer
reviewed
Oct 24, 2022
rboyer
approved these changes
Oct 24, 2022
added 5 commits
October 24, 2022 15:29
These tests started failing in go1.19, presumably due to support for valid 1xx responses being added. golang/go#56346
The service was never successfully running and did not fail any tests
kisunji
force-pushed
the
kisunji/go1.19
branch
from
061b973 to
faec56c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading the go version to 1.19
Highly recommended to review by commit.
Includes:
Note:
The linter
unparamhas not been active in go1.18 due to a bug. This resulted in several features developed recently (peering) to fail the linter in minor ways (unused return variable). I've added TODO's in those files to clean them up