Implements WAN address translation. #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AdvertiseAddrs` has been introduced as a configuration option, which duplicates a few other options, namely `AdvertiseAddrWan`. We need to use this value elsewhere, so rather than doing a precedence check every time we need to access it, rectify the value of `AdvertiseAddrWan` to match
This knob tells consul whether it should prefer the WAN address (if set) when making service lookups in remote datacenters. This enables reachability for remote services which are behind a NAT.
Otherwise, the tests will fail when run on a machine with multiple private addresses
|
This fixes #1386. |
slackpad
added a commit
that referenced
this pull request
Feb 7, 2016
Implements WAN address translation.
|
@slackpad thanks for your awesome work on this! We've been trying to use this feature but unfortunately it seems that it's only available through the DNS interface. What I would really like to see is the appropriately translated address available in the I've been chatting with @evan2645 about this, and he thinks that the above should be do-able. I'm ready to start on a patch but wanted to check with you to see if there was any reason this isn't feasible, or if there was any reason it's a Bad Idea. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the real work here was done by @evan2645 under #1547. This takes that PR and does the following:
TaggedAddressesconfig item. This is populated only with the WAN address for now, but it gives us a good base to expose this as a configurable thing later for additional address tags.Nodestructure member fromAddressestoTaggedAddresses. HavingAddressesnext toAddresswas too subtle (even though it was my original suggestion to name it that, sorry to change it again).leader.go, and it doesn't add any new Serf tags where space is limited.