Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to not create a watch to Internal.ServiceDump when mesh gateway is not used #20168

Merged
merged 13 commits into from
Jan 18, 2024

Conversation

dhiaayachi
Copy link
Collaborator

@dhiaayachi dhiaayachi commented Jan 11, 2024

Description

This add a fix to properly verify the gateway mode before creating a watch specific to mesh gateways. This watch have a high performance cost and when mesh gateways are not used is not used.

This also adds an optimization to only return the nodes when watching the Internal.ServiceDump RPC to avoid unnecessary disco chain compilation. As watches in proxy config only need the nodes.

Testing & Reproduction steps

Added a test to create a set of services with mesh gateway mode default and expecting that this watch is not effective.

Links

PR Checklist

  • updated test coverage
  • appropriate backport labels added
  • not a security concern

@dhiaayachi dhiaayachi added backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17. labels Jan 11, 2024
@dhiaayachi dhiaayachi requested review from hashi-derek, a team and erichaberkorn January 11, 2024 21:12
Copy link
Member

@hashi-derek hashi-derek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent catch. Thank you for tracking this down and fixing it.

@hc-github-team-consul-core
Copy link
Collaborator

@dhiaayachi, a backport is missing for this PR [20168] for versions [1.15,1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.15 This release series is no longer active on CE. Use backport/ent/1.15. backport/1.16 This release series is no longer active on CE. Use backport/ent/1.16. backport/1.17 This release series is no longer active on CE. Use backport/ent/1.17.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants