-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to not create a watch to Internal.ServiceDump
when mesh gateway is not used
#20168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only skip watching gateways when target is not peered
…ways. do not prevent remote gateway watch from being created when a local one exist as both are different.
hashi-derek
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent catch. Thank you for tracking this down and fixing it.
erichaberkorn
approved these changes
Jan 18, 2024
This was referenced Jan 18, 2024
@dhiaayachi, a backport is missing for this PR [20168] for versions [1.15,1.16,1.17] please perform the backport manually and add the following snippet to your backport PR description:
|
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.15
This release series is no longer active on CE. Use backport/ent/1.15.
backport/1.16
This release series is no longer active on CE. Use backport/ent/1.16.
backport/1.17
This release series is no longer active on CE. Use backport/ent/1.17.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This add a fix to properly verify the gateway mode before creating a watch specific to mesh gateways. This watch have a high performance cost and when mesh gateways are not used is not used.
This also adds an optimization to only return the nodes when watching the
Internal.ServiceDump
RPC to avoid unnecessary disco chain compilation. As watches in proxy config only need the nodes.Testing & Reproduction steps
Added a test to create a set of services with mesh gateway mode default and expecting that this watch is not effective.
Links
PR Checklist