Change raft snapshot interval to 5 seconds #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
reviewed
Dec 12, 2016
| @@ -371,6 +374,7 @@ func (s *Server) setupRaft() error { | |||
|
|
|||
| // Make sure we set the LogOutput. | |||
| s.config.RaftConfig.LogOutput = s.config.LogOutput | |||
| s.config.RaftConfig.SnapshotInterval = raftSnapshotInterval | |||
There was a problem hiding this comment.
Since this is a constant and not a late-bound thing like the logger, this should probably go into DefaultConfig() over config.go.
kyhavlov
force-pushed
the
snapshot-interval
branch
from
ba32ce0 to
c49ea15
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for snapshots more frequently to keep the raft file smaller and avoid doing a huge truncation when writing lots of keys very quickly. Should help with #866.