Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gossip verify settings for upshifting to encrypted gossip #3079

Merged
merged 1 commit into from
May 30, 2017

Conversation

kyhavlov
Copy link
Contributor

Adds the encrypt_verify_incoming and encrypt_verify_outgoing options to use the corresponding memberlist settings.

Closes #2141.

Copy link
Contributor

@slackpad slackpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyhavlov kyhavlov merged commit 62f72f1 into master May 30, 2017
@kyhavlov kyhavlov deleted the gossip-upshift branch May 30, 2017 15:51
rolling update of the cluster with these new values. After this step, the agents will be able to
decrypt gossip but will not yet be sending encrypted traffic.
3. Remove the [`encrypt_verify_outgoing`](/docs/agent/options.html#encrypt_verify_outgoing) setting
to change it back to false (the default) and perform another rolling update of the cluster. The
Copy link
Contributor

@sandstrom sandstrom Jun 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyhavlov shouldn't this be

…to change it back to true (the default)

(and ditto for another line, below)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, good catch - the names of these options were changed and the default flipped from false to true. I'll update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants