Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up version 8 ACLs in the agent and the docs. #3248

Merged
merged 4 commits into from
Jul 14, 2017
Merged

Conversation

slackpad
Copy link
Contributor

@slackpad slackpad commented Jul 9, 2017

Closes #2971.

slackpad added 3 commits July 8, 2017 17:29
Since this service is added by the leader, it doesn't really make sense to
also keep it in local state (which requires special ACLs to configure), and
requires a bunch of special cases in the local state logic. This requires
fewer special cases and makes ACL bootstrapping cleaner.
@slackpad slackpad requested review from magiconair and kyhavlov July 9, 2017 07:34
Copy link
Contributor

@kyhavlov kyhavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a typo

@@ -138,6 +175,227 @@ for all servers. Once this is done, restart the current leader to force a leader
Once the ACL system is bootstrapped, ACL tokens can be managed through the
[ACL API](/api/acl.html).

**Create an Agent Token**

After the server are restarted above, you will see new errors in the logs of the Consul
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, should be "After the servers are restarted above"

@slackpad slackpad merged commit 0881e46 into master Jul 14, 2017
@slackpad slackpad deleted the acl-cleanup branch July 14, 2017 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants