Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic if leader step up actions return an error #3350

Closed
slackpad opened this issue Aug 2, 2017 · 1 comment
Closed

Panic if leader step up actions return an error #3350

slackpad opened this issue Aug 2, 2017 · 1 comment
Labels
type/crash The issue description contains a golang panic and stack trace

Comments

@slackpad
Copy link
Contributor

slackpad commented Aug 2, 2017

During some development for #3349 I noticed that if any leader step up actions return an error, you will get a "close of a closed channel" panic in the leader loop. Need to track this down and clean up so that we attempt to step down gracefully and don't panic. Should be reproducible by hacking on establishLeadership() to make it return an error.
@slackpad slackpad added the type/crash The issue description contains a golang panic and stack trace label Aug 2, 2017
@slackpad
Copy link
Contributor Author

slackpad commented Aug 7, 2017

Did some testing on this and I can no longer reproduce it, so I'll close this out as a mid-cycle development thing since lots was going on. We haven't seen any reports of this.

@slackpad slackpad closed this as completed Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/crash The issue description contains a golang panic and stack trace
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slackpad