Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor update miekg/dns to pick up bugfixes and features #3547

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Vendor update miekg/dns to pick up bugfixes and features #3547

merged 1 commit into from
Oct 6, 2017

Conversation

preetapan
Copy link
Contributor

No description provided.

@preetapan preetapan requested a review from slackpad October 6, 2017 18:20
@slackpad slackpad merged commit 285dbe2 into master Oct 6, 2017
@slackpad slackpad deleted the dns_vendor_update branch October 6, 2017 18:34
@slackpad
Copy link
Contributor

slackpad commented Oct 6, 2017 •
edited
Loading

Looks like one test is broken after this merge:

--- FAIL: TestDNS_ServiceLookupWithInternalServiceAddress (0.61s)
        values.go:22: verification for answer at dns_test.go:806:
                [0]/Hdr/Rdlength: Got 27 (0x1b), want 21 (0x15)

There were a lot of compression changes but it's not super clear what happened here, and it seems odd that the data got a little larger after the library update.

@slackpad
Copy link
Contributor

slackpad commented Oct 6, 2017

Unit test issue was fixed in e7dc345.

@slackpad slackpad mentioned this pull request Oct 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slackpad slackpad Awaiting requested review from slackpad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preetapan @slackpad