Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

agent: make the json/hcl decoding of ConnectProxyConfig fully work with CamelCase and snake_case #8741

Merged
merged 2 commits into from
Sep 24, 2020
Merged

agent: make the json/hcl decoding of ConnectProxyConfig fully work with CamelCase and snake_case #8741

merged 2 commits into from
Sep 24, 2020

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Sep 23, 2020

Fixes #7418

@rboyer rboyer requested a review from a team September 23, 2020 21:27
@rboyer rboyer self-assigned this Sep 23, 2020
dnephin
dnephin approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much more consistent!

@rboyer rboyer merged commit 0fb088a into master Sep 24, 2020
@rboyer rboyer deleted the fix-some-json-unmarshal-snake-case-items branch September 24, 2020 18:58
@rboyer rboyer mentioned this pull request Sep 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin approved these changes

Assignees

@rboyer rboyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: error on decode of optional fields on ConnectProxyConfig
2 participants
@rboyer @dnephin