[Streaming] Predictable order for results of /health/service/:serviceName to mimic memdb #9247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Name to mimic memdb This ensures the result is consitent with/witout streaming Will partially fix hashicorp#9239
pierresouchay
force-pushed
the
streaming_predictible_order_for_health
branch
from
7be29a8 to
fb91190
Compare
dnephin
added
the
theme/streaming
dnephin
reviewed
Nov 25, 2020
|
@dnephin All done, thank you for the review |
pierresouchay
force-pushed
the
streaming_predictible_order_for_health
branch
from
6af4104 to
07ba1ff
Compare
* Renamed `cachedHealResultSorter` into `sortCheckServiceNodes` * Use `<` instead of `strings.Compare` * Single line comparison in unit test
pierresouchay
force-pushed
the
streaming_predictible_order_for_health
branch
from
07ba1ff to
76d95fd
Compare
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/288647. |
|
🍒✅ Cherry pick of commit 08b8a92 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Nov 25, 2020
…er_for_health [Streaming] Predictable order for results of /health/service/:serviceName to mimic memdb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the result is consitent with/witout streaming
Will partially fix #9239