Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: Removing formatting to display LockDelay in nanoseconds #9594

Merged
merged 3 commits into from
Jan 20, 2021
Merged

ui: Removing formatting to display LockDelay in nanoseconds #9594

merged 3 commits into from
Jan 20, 2021

Conversation

kaxcode
Copy link
Contributor

@kaxcode kaxcode commented Jan 20, 2021

No description provided.

@kaxcode kaxcode added theme/ui Anything related to the UI backport/1.9 labels Jan 20, 2021
@kaxcode kaxcode requested a review from johncowen January 20, 2021 14:58
johncowen
johncowen suggested changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, I think we just need to fix up the tests - and don't forget to add a changelog (something I keep forgetting about!)

@kaxcode kaxcode requested a review from johncowen January 20, 2021 16:00
johncowen
johncowen approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kaxcode kaxcode merged commit ffb6680 into master Jan 20, 2021
@kaxcode kaxcode deleted the ui/bug/sessions-lock-delay-format branch January 20, 2021 17:03
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/313352.

@hashicorp-ci
Copy link
Contributor

🍒✅ Cherry pick of commit ffb6680 onto release/1.9.x succeeded!

hashicorp-ci pushed a commit that referenced this pull request Jan 20, 2021
@kaxcode @hashicorp-ci
ui: Removing formatting to display LockDelay in nanoseconds (#9594)
7abb869 
* Removing formatting to display LockDelay in nanoseconds

* Update test

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johncowen johncowen johncowen approved these changes

Assignees
No one assigned
Labels
theme/ui Anything related to the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaxcode @hashicorp-ci @johncowen