Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to build "release/1.9.x" branch #9659

Closed
SchweinDeBurg opened this issue Jan 28, 2021 · 3 comments
Closed

Failed to build "release/1.9.x" branch #9659

SchweinDeBurg opened this issue Jan 28, 2021 · 3 comments

Comments

@SchweinDeBurg
Copy link

I've just tried to build "release/1.9.x" branch using Go 1.14.14 and got the following:

github.com/hashicorp/consul/agent/consul
# github.com/hashicorp/consul/agent/consul
agent/consul/server.go:385:5: cannot use s (type *Server) as type serverDelegate in argument to NewGatewayLocator:
	*Server does not implement serverDelegate (missing setDatacenterSupportsFederationStates method)
@blake
Copy link
Contributor

blake commented Jan 28, 2021

Hi @SchweinDeBurg,

This seems to be caused by a change in f25a219, which we should investigate.

In the mean time if you need to build Consul, you should have success with using the last released version, 1.9.2.

$ git checkout v1.9.2
$ git rev-parse --short HEAD
6530cf370
$ make dev
--> Making [GH-xxxx] references clickable...
==> Building Consul - OSes: darwin, Architectures: amd64
Building sequentially with go install
--->   darwin/amd64
$ ./bin/consul version
Consul v1.9.2
Revision 6530cf370
Protocol 2 spoken by default, understands 2 to 3 (agent will automatically use protocol >2 when speaking to compatible agents)

@dnephin
Copy link
Contributor

dnephin commented Jan 28, 2021

Thank you for the bug report! We missed backporting #9519 which caused this issue. I just backported that change now, which looks to have fixed the problem.

We should look at adjusting our backport automation to run tests before accepting the backport so that this doesn't happen again in the future.

@dnephin dnephin closed this as completed Jan 28, 2021
@SchweinDeBurg
Copy link
Author

Many thanks, I've just successfully built an RPM package containing bleeding-edge Consul 1.9.x!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants