ui: Remove any trailing fullstop/period DNS characters from Gateways UI API #9752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous t othis commit, the API response would include Gateway Addresses in the form `domain.name.:8080`, which due to the addition of the port is probably not the expected response. This commit rightTrims any `.` characters from the end of the domain before formatting the address to include the port resulting in `domain.name:8080`
|
🤔 Double check that this PR does not require a changelog entry in the |
johncowen
changed the title
johncowen
changed the title
johncowen
changed the title
crhino
approved these changes
Feb 23, 2021
|
We should probably add a changelog entry for this as well. |
|
Thanks @crhino! I've added a changelog so I'll merge this a little later on 👍 |
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/332203. |
|
🍒✅ Cherry pick of commit 5892e75 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Feb 25, 2021
…UI API (#9752) Previous to this commit, the API response would include Gateway Addresses in the form `domain.name.:8080`, which due to the addition of the port is probably not the expected response. This commit rightTrims any `.` characters from the end of the domain before formatting the address to include the port resulting in `domain.name:8080`
|
🍒✅ Cherry pick of commit 5892e75 onto |
hashicorp-ci
pushed a commit
that referenced
this pull request
Feb 25, 2021
…UI API (#9752) Previous to this commit, the API response would include Gateway Addresses in the form `domain.name.:8080`, which due to the addition of the port is probably not the expected response. This commit rightTrims any `.` characters from the end of the domain before formatting the address to include the port resulting in `domain.name:8080`
dizzyup
pushed a commit
that referenced
this pull request
Apr 21, 2021
…UI API (#9752) Previous to this commit, the API response would include Gateway Addresses in the form `domain.name.:8080`, which due to the addition of the port is probably not the expected response. This commit rightTrims any `.` characters from the end of the domain before formatting the address to include the port resulting in `domain.name:8080`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this commit, the API response for getting information about the upstreams for a gateway (
/v1/internal/ui/gateway-services-nodes/:gateway) would include Gateway Addresses in the formdomain.name.:8080, which due to the addition of the port is probably not the expected format (the trailing.is DNS not Address:Port URLs).This commit rightTrims any
.characters from the end of the domain before formatting the address to include the port resulting indomain.name:8080One thing I'm unsure of, whilst this 'fixes' things for displaying this in the UI, does this effect anything else backend related? I had a quick search to see is the
.Addresses()method was being used elsewhere, and I couldn't see anything, but would be good to double check.