Send SOA with negative responses (RFC2308) #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, could you add a test for this as well? There is already a fairly complete test for this exact method, it could be extended to verify SOA presence as well. |
42wim
force-pushed
the
rfc2308-soa-ttl
branch
2 times, most recently
from
08c367d to
76792ff
Compare
|
I extended TestDNS_NodeLookup and TestDNS_ServiceLookup. |
|
Anything else needed for possible merge ? |
|
Hey @42wim, sorry for the delay. Could you rebase this against master? I made some changes to the |
|
Sure, here you go. |
|
When can this fix be merged? Our DNS needs this too :-) |
|
+1 because of Windows needing this too. |
|
LGTM, thanks for doing this! |
ryanuber
added a commit
that referenced
this pull request
Jul 13, 2015
Send SOA with negative responses (RFC2308)
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC:
"Name servers authoritative for a zone MUST include the SOA record of the zone in the authority section of the response when reporting an NXDOMAIN or indicating that no data of the requested type exists."
This fixes issues with DNS recursors caching negative responses too long (e.g. PowerDNS recursor)