Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Localized ipconfig output incompatible with regex that extracts IP addresses #30

Open
angrycub opened this issue Feb 4, 2019 · 0 comments
Open

Windows: Localized ipconfig output incompatible with regex that extracts IP addresses #30

angrycub opened this issue Feb 4, 2019 · 0 comments

Comments

@angrycub
Copy link
Contributor

angrycub commented Feb 4, 2019

Since the output of ipconfig is localized, it is possible for it to become unparsable via this library. This is the root cause for hashicorp/nomad#5298

go-sockaddr/ifaddrs.go

Line 20 in 3aed17b

ipAddrRE *regexp.Regexp = regexp.MustCompile(`^ IPv[46] Address\. \. \. \. \. \. \. \. \. \. \. : ([^\s]+)`)

@angrycub angrycub changed the title Localized ipconfig output incompatible with regex that extracts IP addresses Windows: Localized ipconfig output incompatible with regex that extracts IP addresses Feb 4, 2019
@angrycub angrycub mentioned this issue Jan 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@angrycub