-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable application side logging of hashicat runtime #68
Comments
For some context on why this was implemented the way it is, here is a snipped from a document I wrote up based on a bit of research I did on the current thoughts about enabling logging in libraries. -- Discussions about a more featureful standard logging library.
The conclusion is to keep it simple but make it an interface. They discarded Instead the decided convention that best enabled logging to plug into a library
Notably this paragraph.. ("our proposal" being a new log package proposal)
The httptrace package, used above as an example of what this might look like, This works but is clumsey and only extensible by adding more functions, but has |
Add support for injecting a logger into the Watcher to support logging it's events.
Should allow for injecting our logger, go-hclog, but should attempt to be as generic as possible.
The text was updated successfully, but these errors were encountered: