Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memberlist logger should be exported #39

Open
cousine opened this issue Jun 13, 2015 · 3 comments
Open

Memberlist logger should be exported #39

cousine opened this issue Jun 13, 2015 · 3 comments

Comments

@cousine
Copy link

cousine commented Jun 13, 2015

Hi there,

I think the logger should be exported instead of the LogOutput in the configuration; I'm using a custom logger with a custom format however I must hack a custom io.Writer to have memberlist use my custom logger.

@ryanuber
Copy link
Member

Hey @cousine, seems reasonable to use a custom logger. Instead of exporting it directly in the struct, maybe we could do like a CreateLogger(*Config, *log.Logger) analogous to the Create method or something to that effect.

@cousine
Copy link
Author

cousine commented Jun 16, 2015

Yeah that would be very helpful 👍 but I'd call it CreateWithLogger tbh 😄

I'll see if I can make a PR for that change

@JensRantil
Copy link

See also #76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants