Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gossip broadcasts different state to the random nodes in one iteration #75

Open
mrjana opened this issue Mar 24, 2016 · 2 comments
Open

Comments

@mrjana
Copy link

mrjana commented Mar 24, 2016

Reading the code here https://github.com/hashicorp/memberlist/blob/master/state.go#L403 it looks like the broadcast queue is read each time for all the k random nodes(which re-sorts the broadcast queue) so every node selected to get a gossip update is going to get different set of data in a single gossip. Is this intentional? I would have though that the intention would have been to gossip the exact state to all the random nodes in a single iteration.

@slackpad
Copy link
Contributor

Hi @mrjana I might be missing something, but I don't see where the broadcast queue is randomized on each trip through the loop. It looks like it runs the same steps for each randomly-chosen member and the broadcast contents will only change during that loop if a transmit limit is set.

@JensRantil
Copy link

Given there has been no activity here for almost three years I propose this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants