From 8be12ee992056703f9fcfffc8df99177fd9e1630 Mon Sep 17 00:00:00 2001 From: Alex Dadgar Date: Fri, 16 Mar 2018 10:52:19 -0700 Subject: [PATCH] Pull snapshotting out of loop --- nomad/job_endpoint.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/nomad/job_endpoint.go b/nomad/job_endpoint.go index 44199ca980e..04360d49b81 100644 --- a/nomad/job_endpoint.go +++ b/nomad/job_endpoint.go @@ -674,17 +674,18 @@ func (j *Job) BatchDeregister(args *structs.JobBatchDeregisterRequest, reply *st } } + // Grab a snapshot + snap, err := j.srv.fsm.State().Snapshot() + if err != nil { + return err + } + // Loop through to create evals for jobNS, options := range args.Jobs { if options == nil { return fmt.Errorf("no deregister options provided for %v", jobNS) } - // Lookup the job - snap, err := j.srv.fsm.State().Snapshot() - if err != nil { - return err - } job, err := snap.JobByID(nil, jobNS.Namespace, jobNS.ID) if err != nil { return err