Return buffered text from log endpoint if decoding fails #15558
Conversation
|
@benbuzbee is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Hi @benbuzbee and thanks for raising this PR. I agree it makes the error much easier to understand.
CI is currently failing as the API Go module is missing the multi-error package dependency. If you have the time, could you update the module to include this? Additionally a changelog improvement entry would be great also.
To see why I think this is a good change lets look at why I am making it My disk was full, which means GC was happening agressively. So by the time I called the logging endpoint from the SDK, the logs were GC'd The error I was getting before was: ``` invalid character 'i' in literal false (expecting 'l') ``` Now the error I get is: ``` failed to decode log endpoint response as JSON: "failed to list entries: open /tmp/nomad.data.4219353875/alloc/f11fee50-2b66-a7a2-d3ec-8442cb3d557a/alloc/logs: no such file or directory" ``` Still not super descriptive but much more debugable
benbuzbee
force-pushed
the
benbuz/log-error
branch
from
05e5a26 to
024f7bb
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for looking @jrasell - I force pushed an update |
To see why I think this is a good change lets look at why I am making it My disk was full, which means GC was happening agressively. So by the time I called the logging endpoint from the SDK, the logs were GC'd The error I was getting before was: ``` invalid character 'i' in literal false (expecting 'l') ``` Now the error I get is: ``` failed to decode log endpoint response as JSON: "failed to list entries: open /tmp/nomad.data.4219353875/alloc/f11fee50-2b66-a7a2-d3ec-8442cb3d557a/alloc/logs: no such file or directory" ``` Still not super descriptive but much more debugable
…5796) To see why I think this is a good change lets look at why I am making it My disk was full, which means GC was happening agressively. So by the time I called the logging endpoint from the SDK, the logs were GC'd The error I was getting before was: ``` invalid character 'i' in literal false (expecting 'l') ``` Now the error I get is: ``` failed to decode log endpoint response as JSON: "failed to list entries: open /tmp/nomad.data.4219353875/alloc/f11fee50-2b66-a7a2-d3ec-8442cb3d557a/alloc/logs: no such file or directory" ``` Still not super descriptive but much more debugable Co-authored-by: Benjamin Buzbee <[email protected]>
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
To see why I think this is a good change lets look at why I am making it
My disk was full, which means GC was happening agressively. So by the time I called the logging endpoint from the SDK, the logs were GC'd
The error I was getting before was:
Now the error I get is:
Still not super descriptive but much more debugable