Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numa: fix cpu topology conversion for non linux systems #18843

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

shoenig
Copy link
Contributor

@shoenig shoenig commented Oct 24, 2023

The linux path is unchanged (just moved into _linux file). The non-linux path now no longer references dead / unusable fields on non-linux systems.

E.g. is meaningless outside of Linux.

cores := n.Processors.Topology.UsableCores().Slice()
n.Cpu.ReservableCpuCores = helper.ConvertSlice(cores, func(coreID hw.CoreID) uint16 {
	return uint16(coreID)
})

Also fixes the use of "power" where we meant "performance" in reference to M1/M2 P-Cores in the attributes.

@shoenig shoenig marked this pull request as ready for review October 24, 2023 12:55
@shoenig shoenig requested review from lgfa29 and tgross October 24, 2023 12:59
@shoenig shoenig added this to the 1.7.0 milestone Oct 24, 2023
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the pointers on the file moves... it makes it easier to review side-by-side 😀

Copy link

github-actions bot commented Feb 7, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants