Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Shows the client/node name alongside alloc short ID if the job is system/sysbatch #19051

Conversation

philrenaud
Copy link
Contributor

On hover, shows client info on the job status panel's allocs:
image

Resolves #19050

Copy link

github-actions bot commented Nov 9, 2023

Ember Test Audit comparison

main 2bab2f3 change
passes 1538 1538 0
failures 0 0 0
flaky 0 0 0
duration 10m 42s 962ms 10m 51s 554ms +08s 592ms

@philrenaud philrenaud requested a review from juliezzhou November 9, 2023 21:01
Copy link

@juliezzhou juliezzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Unverified

This user has not yet uploaded their public signing key.
…/sysbatch
@philrenaud philrenaud force-pushed the f-ui/19050-ui-in-the-job-status-panel-tooltips-for-allocations-in-a-system-job-should-show-node-name branch from 8830ea1 to 2bab2f3 Compare November 15, 2023 14:29
@philrenaud philrenaud merged commit bb6c86d into main Nov 15, 2023
@philrenaud philrenaud deleted the f-ui/19050-ui-in-the-job-status-panel-tooltips-for-allocations-in-a-system-job-should-show-node-name branch November 15, 2023 15:05
Copy link

github-actions bot commented Feb 3, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] In the Job Status panel, tooltips for allocations in a system job should show node name
2 participants