Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Display job plan warnings alongside dry run info when attempting to run a job through the web UI #19225

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented Nov 29, 2023

Shows warnings from job plan (dry-run) in the Nomad web UI.

Passes along the string that we show in the CLI and otherwise:

$ nomad job run  -var="count=4" ../nomad-job-specs/bug-empty-variables.nomad.hcl
Job Warnings:
2 warnings:

* Group "cache" has warnings: 1 error occurred:
	* Task "redis" has warnings: 1 error occurred:
	* 2 errors occurred:
	* Identity[vault_default] identities without an audience are insecure
	* Identity[vault_default] identities without an expiration are insecure
* Task redis has an identity called vault_default but no vault block

Also, updated the notification/alert to Helios.

Before:
image

After:
image

After, no placement errors:
image

Resolves #19014

Copy link

github-actions bot commented Nov 29, 2023

Ember Test Audit comparison

main 99cf94f change
passes 1539 1540 +1
failures 0 0 0
flaky 0 0 0
duration 10m 50s 913ms 10m 51s 270ms +357ms

@philrenaud philrenaud force-pushed the 19014-ui-display-job-plan-warnings-alongside-dry-run-info-when-attempting-to-run-a-job-through-the-web-ui branch from cadf406 to 40fc25d Compare November 29, 2023 21:28
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks Phil! Somebody we'll have to figure out a format for structured warnings/errors/placement-failures, but in the mean time this should make our warnings a lot more visible.

@philrenaud philrenaud force-pushed the 19014-ui-display-job-plan-warnings-alongside-dry-run-info-when-attempting-to-run-a-job-through-the-web-ui branch from b974725 to 99cf94f Compare November 30, 2023 15:19
@philrenaud philrenaud merged commit 7ab7edf into main Nov 30, 2023
11 checks passed
@philrenaud philrenaud deleted the 19014-ui-display-job-plan-warnings-alongside-dry-run-info-when-attempting-to-run-a-job-through-the-web-ui branch November 30, 2023 15:41
Copy link

github-actions bot commented Feb 1, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.6.x backport to 1.6.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] display job plan warnings alongside dry run info when attempting to run a job through the web UI
2 participants