-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] Display job plan warnings alongside dry run info when attempting to run a job through the web UI #19225
Conversation
79fe611
to
cadf406
Compare
Ember Test Audit comparison
|
cadf406
to
40fc25d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks Phil! Somebody we'll have to figure out a format for structured warnings/errors/placement-failures, but in the mean time this should make our warnings a lot more visible.
b974725
to
99cf94f
Compare
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Shows warnings from
job plan
(dry-run) in the Nomad web UI.Passes along the string that we show in the CLI and otherwise:
Also, updated the notification/alert to Helios.
Before:
![image](https://private-user-images.githubusercontent.com/713991/286738989-f60b9bf3-593a-49a0-93d5-7be404c2e4e2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMDQyODAsIm5iZiI6MTczOTAwMzk4MCwicGF0aCI6Ii83MTM5OTEvMjg2NzM4OTg5LWY2MGI5YmYzLTU5M2EtNDlhMC05M2Q1LTdiZTQwNGMyZTRlMi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwODM5NDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04NzBhMWI3YjgwNWFjNGZiYTRkMzA1NjhkZDNjYzMzM2QyOGFlODczNGVhMTJmYjQxOTFmNzk5NmRlMTBkZDQ2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.J681s2MAFettQW8TavHtYjEzDIOhWebI-IOBFctCf3s)
After:
![image](https://private-user-images.githubusercontent.com/713991/286739022-3c713a13-d165-4345-afb3-3fce7ff1653d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMDQyODAsIm5iZiI6MTczOTAwMzk4MCwicGF0aCI6Ii83MTM5OTEvMjg2NzM5MDIyLTNjNzEzYTEzLWQxNjUtNDM0NS1hZmIzLTNmY2U3ZmYxNjUzZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwODM5NDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xNGU5MzliNDU0MzgwMzg3YzcxYWUyOWM2OTFlNTRjYzY1NjQyOGU1OTMyOTYzZDQ3MzRhYTQ1NzA5NzUyZTcwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.O5ViEPQAoUVbRa3jp2WMyxO28SoxHcXAOlsRa3JRMjs)
After, no placement errors:
![image](https://private-user-images.githubusercontent.com/713991/286739059-2971ee83-49fc-4ccb-81e0-2469f4f823ae.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMDQyODAsIm5iZiI6MTczOTAwMzk4MCwicGF0aCI6Ii83MTM5OTEvMjg2NzM5MDU5LTI5NzFlZTgzLTQ5ZmMtNGNjYi04MWUwLTI0NjlmNGY4MjNhZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwODM5NDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mZDgwNTRlYzZhZDBjYTVkMzRjM2M1NzcxNGRkMWI1OTMxYThlMzA4Yzg2MTJhYmY0ZTRjNjhhNGQ1YmFkYmRiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.V7Q2iSTXFQrI_TcfQzgifju2cTfsQs-77XpL92ao9Po)
Resolves #19014