Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: dead links/incorrect links #19456

Closed
benvanstaveren opened this issue Dec 13, 2023 · 4 comments · Fixed by #19424
Closed

Documentation: dead links/incorrect links #19456

benvanstaveren opened this issue Dec 13, 2023 · 4 comments · Fixed by #19424
Assignees
Labels
theme/docs Documentation issues and enhancements theme/vault type/bug

Comments

@benvanstaveren
Copy link

benvanstaveren commented Dec 13, 2023

In the documentation for vault integration (https://developer.hashicorp.com/nomad/docs/integrations/vault-integration#migrating-to-using-workload-identity-with-vault) there are 2 links referenced that go to the wrong section and basically do not work:

Enable vault.default_identity blocks in your Nomad server agent configurations.

(Optionally) Add vault.role fields to any Nomad jobs that will not use the default role.

The "consul" section does not have said anchors, and since we're talking about vault integration I'm pretty sure they need to be sent to the vault block(s) docs.

@tgross tgross added the theme/docs Documentation issues and enhancements label Dec 13, 2023
@lgfa29 lgfa29 self-assigned this Dec 13, 2023
@lgfa29
Copy link
Contributor

lgfa29 commented Dec 13, 2023

Thanks for the report @benvanstaveren!

I'm reworking some content on this page so I will make sure to fix this link as well.

@benvanstaveren
Copy link
Author

Cheers! Maybe also add some documentation on what is supported on the JWT's claim_mappings, right now from the example all I can see is the nomad namespace and job id, and I'd love to be able to get some of the job's metadata into the claim mapping as well, somehow... but it doesn't mention if that's possible or how to go about that :D

@tgross
Copy link
Member

tgross commented Dec 14, 2023

#19424 has updates on what's available.

and I'd love to be able to get some of the job's metadata into the claim mapping as well, somehow... but it doesn't mention if that's possible or how to go about that

It's not currently possible. We've got #19438 open discussing that. If you'd like to chime in with some motivating use cases, that'd be super helpful!

Copy link

github-actions bot commented Jan 2, 2025

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/docs Documentation issues and enhancements theme/vault type/bug
Projects
Development

Successfully merging a pull request may close this issue.

3 participants