Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support insecure flag on artifact #19883

Closed
lgfa29 opened this issue Feb 6, 2024 · 1 comment · Fixed by #20126
Closed

Support insecure flag on artifact #19883

lgfa29 opened this issue Feb 6, 2024 · 1 comment · Fixed by #20126
Labels
good first issue help-wanted We encourage community PRs for these issues! stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/artifact type/enhancement

Comments

@lgfa29
Copy link
Contributor

lgfa29 commented Feb 6, 2024

Proposal

hashicorp/go-getter#319 added a new configuration to allow go-getter to fetch artifacts from sources where their TLS certificate is not trusted by the system, but Nomad has this value hard-coded to false.

return &getter.Client{
Ctx: ctx,
Src: p.Source,
Dst: p.Destination,
Mode: p.Mode,
Umask: umask,
Insecure: false,

In some scenarios it may be useful to fetch artifacts from sources with self-signed certificates, which checksum providing some level of file tempering protection.

Use-cases

Retrieve artifacts from sources exposed with self-signed certificates.

@lgfa29 lgfa29 added type/enhancement good first issue theme/artifact stage/accepted Confirmed, and intend to work on. No timeline committment though. help-wanted We encourage community PRs for these issues! labels Feb 6, 2024
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue help-wanted We encourage community PRs for these issues! stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/artifact type/enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant