Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exhausted node metrics reporting in preemption #20346

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

gabivlj
Copy link
Contributor

@gabivlj gabivlj commented Apr 10, 2024

If preemption is enabled, Nomad doesn't report back the devices: no devices match request when it does not find an allocation to evict.

This allows admins to check why allocations are not being placed when preemption is configured in Nomad.

@gabivlj
Copy link
Contributor Author

gabivlj commented Apr 10, 2024

Hi @tgross I think this is real useful for us, do these changes look good to you?

Thank you!

@tgross tgross self-requested a review April 10, 2024 12:36
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I've added a changelog entry and once CI is done again, I'll get this merged. Thanks @gabivlj!

Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants