Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: fix unallocated CPU metric when reserved cpu is set. #20543

Merged
merged 2 commits into from
May 9, 2024
Merged

client: fix unallocated CPU metric when reserved cpu is set. #20543

merged 2 commits into from
May 9, 2024

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented May 8, 2024

closes #20521

@jrasell jrasell added the backport/1.7.x backport to 1.7.x release line label May 8, 2024
@jrasell jrasell requested review from shoenig, tgross and gulducat May 8, 2024 11:30
@jrasell jrasell self-assigned this May 8, 2024
@jrasell jrasell marked this pull request as ready for review May 8, 2024 12:05
tgross
tgross approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jrasell jrasell merged commit 7e42ad8 into main May 9, 2024
19 checks passed
@jrasell jrasell deleted the b-gh-20521 branch May 9, 2024 09:55
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request May 9, 2024
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

@ostkrok ostkrok ostkrok approved these changes

@shoenig shoenig Awaiting requested review from shoenig

@gulducat gulducat Awaiting requested review from gulducat

Assignees

@jrasell jrasell

Labels
backport/1.7.x backport to 1.7.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reserved CPU is counted twice
3 participants
@jrasell @tgross @ostkrok