-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Source environment variables from consul-template #2217
Comments
Hey, This is a duplicate of this issue: #1765 Hopefully be able to have this functionality soon 👍 |
Hi @dadgar, I think there is still a usage to include the env_file option, at least for the Docker driver. You might want to download this env file from an artefact, or use advanced consul-template options in order to generate your env file. Would you refuse a PR implementing that change ? |
@nanoz Can you explain a case where you would need an env_file given that the job file allows you to specify environment variables and env_consul support? Generally avoid having many ways to do one thing. |
@dadgar This a general problem with development workflow: when nomad is ready to fire - there is already the whole bunch of settings for an application: All that should be stored in consul, but nomad can't read yet from consul kv yet. Sometimes it won't be able to, when the job is triggered from managed CI server. Nomad should get a first class support of making deploy step as easy as possible. Amazon provided an elegant solution for lambda for a very similar problem. |
@rokka-n Reading from Consul would happen at the clients not on the machine that submits the job so the CI example wouldn't be a problem. Further we support adding environment variables natively: https://www.nomadproject.io/docs/job-specification/env.html. |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Hi guys,
I wonder how do you manage environment variables from consul k/v ?
We would like to use your implementation of consul-template with the template stanza, but there is no way to “source” the generated file.
What do you think about developing an env_file stanza in config or task ? Like the following:
or
The text was updated successfully, but these errors were encountered: