[ui] Remove simulacral allocation stat in favor of live-updating one #23306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrenaud
commented
Jun 11, 2024
| @@ -185,6 +185,10 @@ export default class JobStatusPanelSteadyComponent extends Component { | |||
| return this.job.allocations.filter((a) => !a.isOld && a.hasBeenRestarted); | |||
| } | |||
|
|
|||
| get runningAllocs() { | |||
| return this.job.allocations.filter((a) => a.clientStatus === 'running'); | |||
| } | |||
There was a problem hiding this comment.
@job.runningAllocs comes from the job's summary as defined here in case you were curious
Ember Test Audit comparison
|
shoenig
approved these changes
Jun 12, 2024
philrenaud
force-pushed
the
20627-current-job-overview-summary-page-is-reporting-disparate-numbers-for-running-allocations-segals-law
branch
from
8e641ed to
b8880c0
Compare
philrenaud
deleted the
20627-current-job-overview-summary-page-is-reporting-disparate-numbers-for-running-allocations-segals-law
branch
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While most of our job status panel allocation numbers use allocations live as they're updated from the /allocations endpoint for a given job, one holdout remained: the the "X Allocations Running" number came from the
job-summary, which tabulates at a slightly different time than allocations do (and is sometimes susceptible to inaccuracy)This changes the number in steady-state jobs to be what we actually see among currently running allocations from the /allocations endpoint. This doesn't discriminate between new-version and old-version allocations, only returning the number currently running.
Resolves #20627