Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls: support setting min version to TLS1.3 #23713

Merged
merged 1 commit into from
Aug 1, 2024
Merged

tls: support setting min version to TLS1.3 #23713

merged 1 commit into from
Aug 1, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Jul 31, 2024

Nomad already supports TLS1.3, but not as a minimum version configuration. Update our config validation to allow setting tls_min_version to 1.3. Update the documentation to match Vault and warn that the tls_cipher_suites field is ignored when TLS is 1.3

Fixes: #20131
Ref: https://hashicorp.atlassian.net/browse/NET-10530

Nomad already supports TLS1.3, but not as a minimum version
configuration. Update our config validation to allow setting `tls_min_version`
to 1.3. Update the documentation to match Vault and warn that the
`tls_cipher_suites` field is ignored when TLS is 1.3

Fixes: #20131
Ref: https://hashicorp.atlassian.net/browse/NET-10530
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross merged commit 2ee6043 into main Aug 1, 2024
33 checks passed
@tgross tgross deleted the tls-allow-tls13 branch August 1, 2024 12:46
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow tls13 for tls_min_version
3 participants