Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: fix -t flag on job status command #24054

Merged
merged 1 commit into from
Sep 25, 2024
Merged

cli: fix -t flag on job status command #24054

merged 1 commit into from
Sep 25, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Sep 24, 2024

In #18925 we added a -json flag to the job status command, but the argument handling had a bug where it would always set the -json flag if either the -t or -json flags were set, resulting in a misleading error. Instead, pass the -json flag value into the formatter.

Fixes: #24050

@tgross tgross mentioned this pull request Sep 24, 2024
Closed
@tgross tgross force-pushed the cli-job-status-template-flag branch from 3834b33 to e1b83d8 Compare September 24, 2024 14:11
@tgross
cli: fix -t flag on job status command
3203706 
In #18925 we added a `-json` flag to the `job status` command, but the argument
handling had a bug where it would always set the `-json` flag if either the `-t`
or `-json` flags were set, resulting in a misleading error. Instead, pass the
`-json` flag value into the formatter.

Fixes: #24050
@tgross tgross force-pushed the cli-job-status-template-flag branch from e1b83d8 to 3203706 Compare September 24, 2024 17:32
@tgross tgross marked this pull request as ready for review September 24, 2024 17:53
@tgross tgross added this to the 1.9.0 milestone Sep 24, 2024
@tgross tgross requested a review from pkazmierczak September 24, 2024 20:47
pkazmierczak
pkazmierczak approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross added backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/1.8.x backport to 1.8.x release line labels Sep 25, 2024
@tgross tgross merged commit 65ec00d into main Sep 25, 2024
32 checks passed
@tgross tgross deleted the cli-job-status-template-flag branch September 25, 2024 13:12
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Sep 25, 2024
Merged
@pgporada
Copy link
Contributor

Thanks again!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pkazmierczak pkazmierczak pkazmierczak approved these changes

@gulducat gulducat Awaiting requested review from gulducat

@mismithhisler mismithhisler Awaiting requested review from mismithhisler

Assignees
No one assigned
Labels
backport/ent/1.7.x+ent Changes are backported to 1.7.x+ent backport/1.8.x backport to 1.8.x release line
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Cannot use go templates for job status output
3 participants
@tgross @pgporada @pkazmierczak