Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Adds an ellipsis and max width to profile nav token name #24240

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

philrenaud
Copy link
Contributor

Maxes out the width of the profile dropdown for token name so that it isn't as likely to bump into the searchbox etc.

image

(Note: a better, and eventual, solution to this is to use css grid or flexbox, but today is not that day)

Copy link

github-actions bot commented Oct 17, 2024

Ember Test Audit comparison

main 260fdfb change
passes 1581 1581 0
failures 0 0 0
flaky 0 0 0
duration 12m 22s 833ms 12m 21s 067ms -01s 766ms

Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@philrenaud philrenaud added the backport/1.9.x backport to 1.9.x release line label Oct 17, 2024
@philrenaud philrenaud force-pushed the f-ui/horizontally-overflow-token-name branch from 27cacfd to 260fdfb Compare October 18, 2024 03:48
@philrenaud philrenaud merged commit ec53ccc into main Oct 18, 2024
13 of 14 checks passed
@philrenaud philrenaud deleted the f-ui/horizontally-overflow-token-name branch October 18, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.9.x backport to 1.9.x release line theme/ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants