-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: Fix a bug where images with port number and no tags weren't parsed correctly #24547
Conversation
Hi does something is missing in this PR to be review? |
could I have a feeback on this PR? I supose i'm not alone to use private registry? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vincentDcmps, thanks a lot for the PR and apologies it took a while for anyone to take a look at it. Code looks good to me, I only left a formatting suggestion. Would you also mind adding a small changelog entry? You can make it with make cl
, something like:
docker: Fix a bug where images with port number and no tags weren't parsed correctly.
Then I'm happy to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks, @vincentDcmps!
Description
when using private registry without any image tag pull get Invalid reference format issue
Testing & Reproduction steps
on version 1.9.4 send a job with image with following format:
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.