Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Fix a bug where images with port number and no tags weren't parsed correctly #24547

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

vincentDcmps
Copy link
Contributor

@vincentDcmps vincentDcmps commented Nov 23, 2024

Description

when using private registry without any image tag pull get Invalid reference format issue

Testing & Reproduction steps

on version 1.9.4 send a job with image with following format:

ghcr.service.consul:5000/paperless-ngx/paperless-ng

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@vincentDcmps vincentDcmps requested review from a team as code owners November 23, 2024 17:07
Copy link

hashicorp-cla-app bot commented Nov 23, 2024

CLA assistant check
All committers have signed the CLA.

@vincentDcmps
Copy link
Contributor Author

Hi does something is missing in this PR to be review?

@vincentDcmps
Copy link
Contributor Author

could I have a feeback on this PR? I supose i'm not alone to use private registry?

@pkazmierczak pkazmierczak self-assigned this Jan 3, 2025
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vincentDcmps, thanks a lot for the PR and apologies it took a while for anyone to take a look at it. Code looks good to me, I only left a formatting suggestion. Would you also mind adding a small changelog entry? You can make it with make cl, something like:

docker: Fix a bug where images with port number and no tags weren't parsed correctly.

Then I'm happy to merge.

drivers/docker/driver_test.go Outdated Show resolved Hide resolved
@pkazmierczak pkazmierczak added the backport/1.9.x backport to 1.9.x release line label Jan 3, 2025
@pkazmierczak pkazmierczak added this to the 1.9.x milestone Jan 3, 2025
@pkazmierczak pkazmierczak changed the title fix: case where image got port number and not tag docker: Fix a bug where images with port number and no tags weren't parsed correctly Jan 3, 2025
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @vincentDcmps!

@pkazmierczak pkazmierczak merged commit 6469b59 into hashicorp:main Jan 3, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.9.x backport to 1.9.x release line
Projects
Development

Successfully merging this pull request may close these issues.

2 participants