UI: Log streaming #3564
UI: Log streaming #3564
Conversation
ui/app/utils/classes/log.js
Outdated
| }; | ||
|
|
||
| if (window.ReadableStream) { | ||
| this.set('logStreamer', StreamLogger.create(args)); |
There was a problem hiding this comment.
Maybe have a StreamLogger.isSupported() method so you don't have to use window.ReadableStream everywhere. Then in create() you can also assert that it's supported.
ui/app/utils/classes/log.js
Outdated
| this.stop(); | ||
| let text = yield logFetch(url).then(res => res.text()); | ||
|
|
||
| if (text.length > 50000) { |
There was a problem hiding this comment.
Counting newlines might be more fair and/or fit your window better but I can see why you'd also do this instead.
ui/app/utils/classes/poll-logger.js
Outdated
| } else { | ||
| additionalParams = { | ||
| origin: 'end', | ||
| offset: 50000, |
There was a problem hiding this comment.
I wonder if you might wanna throw 50000 in a config file since it's used in several spots.
| @@ -20,7 +20,10 @@ | |||
| "prettier --single-quote --trailing-comma es5 --print-width 100 --write", | |||
| "git add" | |||
| ], | |||
| "ui/app/styles/**/*.*": ["prettier --write", "git add"] | |||
| "ui/app/styles/**/*.*": [ | |||
There was a problem hiding this comment.
npm/yarn and prettier always fight the formatting of these lines. I try to make prettier win since that's easier to keep up with.
Supports:
- Reading the head of a log
- Reading the tail of a log
- Following a log in one of two ways:
- Streaming the HTTP request (using fetch res.getReader)
- Polling the log endpoint (using EC timeouts)
Just verifying the log code works
Until they can be mocked, they can't be used
This will need to get better for testing the offset stitching logic in the polling case.
DingoEatingFuzz
force-pushed
the
f-ui-log-streaming
branch
from
7e41b6b to
d930180
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
:o
Supports:
In order to not destroy browsers, the log will only show 50k characters. When streaming or reading the tail, anything before the last 50k characters will be truncated. When reading the head, anything after the first 50k characters will be truncated.
Having scroll back is nice, and I want to make this better, but I think this is a good first iteration.