Support Consul gRPC Health Checks #4251
Conversation
schmichael
force-pushed
the
f-grpc-checks
branch
2 times, most recently
from
f3b985d to
698adc0
Compare
vendor/vendor.json
Outdated
| @@ -2,355 +2,2064 @@ | |||
| "comment": "", | |||
| "ignore": "test appengine", | |||
| "package": [ | |||
| {"path":"context","revision":""}, | |||
| ``` | ||
|
|
||
| This check would translate to having a Consul check registration with the | ||
| [GRPC][consul_grpc] parameter similar to `10.0.3.1:4567/grpc.health.v1.Health`. |
There was a problem hiding this comment.
its not clear what "parameter similar to 10.0.3.1:4567/grpc.health.V1.health" means here
There was a problem hiding this comment.
Consul only has a single grpc field that takes the full <host>:<port>/<endpoint> like a URL. Nomad can't do that because the host and port are determined at runtime.
So I'm trying to describe how Nomad's fields relate to the Consul field, but yeah... this is worded badly. Perhaps the fact that it's a single grpc field in Consul is an implementation detail I don't actually have to worry about comparing against?
🤔 I'll get this changed or remove it, but let me know if you have any suggestions!
| Assuming the service's address is `10.0.3.1` and port is `4567`. See [Using | ||
| Driver Address Mode](#using-driver-address-mode) for details on address | ||
| selection. | ||
| In this example Consul would health check the `grpc.health.v1.Health` service |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Add support for gRPC health checks. Tested against etcd and an altered greeter_server.
greeter_server.gz
patch
grpchealth.nomad
Bumped vendored Consul libraries to 1.0.7 which also required bumping Serf.