Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Require setup-terraform to be run before action #255

Merged
merged 6 commits into from
Jan 23, 2025

Conversation

mutahhir
Copy link
Member

Related issue

Fixes #243

Description

This PR makes it so that this action doesn't install Terraform automatically. The expectation is that terraform with the specific version is already installed on the runner. This can be done with the setup-terraform action. The examples are updated to explain the usage.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mutahhir mutahhir marked this pull request as ready for review January 23, 2025 09:39
@mutahhir mutahhir requested a review from a team as a code owner January 23, 2025 09:39
@mutahhir mutahhir requested review from ansgarm and DanielMSchmidt and removed request for a team January 23, 2025 09:39
@mutahhir mutahhir force-pushed the chore/upgrade-action branch from 70fb991 to 34fa266 Compare January 23, 2025 10:01
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good – just one optional thing, feel free to dismiss

@mutahhir mutahhir enabled auto-merge (squash) January 23, 2025 10:39
Signed-off-by: team-tf-cdk <[email protected]>
@mutahhir mutahhir merged commit 93a2633 into main Jan 23, 2025
5 checks passed
@mutahhir mutahhir deleted the chore/upgrade-action branch January 23, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npx cdktf-get doesn't work without the terraform CLI anymore
3 participants