Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output version to stdout rather than stderr #185

Closed
radeksimko opened this issue Jun 25, 2020 · 2 comments · Fixed by #296
Closed

Output version to stdout rather than stderr #185

radeksimko opened this issue Jun 25, 2020 · 2 comments · Fixed by #296
Labels
bug Something isn't working

Comments

@radeksimko
Copy link
Member

This seems like an unfortunate oversight:
https://github.com/hashicorp/vscode-terraform/blob/1c882b35bb52e834214fad186c167f8ecaf04804/src/languageServerInstaller.ts#L32

I'm not sure yet how to fix it in a backwards-compatible way though and what would happen if stderr became empty.

Server Version

0.3.2

Expected Behavior

terraform-ls --version printed out to stdout.

Actual Behavior

terraform-ls --version printed out to stderr.

@radeksimko
Copy link
Member Author

I suspect the major "customer" of this API is really just VSCode for now and I'm thinking we could just read stdout+stderr for a while: hashicorp/vscode-terraform#418

@ghost
Copy link

ghost commented Feb 6, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant