Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module.calls: Report requirements and installed versions separately #994

Open
Tracked by #1173
radeksimko opened this issue Jul 7, 2022 · 0 comments
Open
Tracked by #1173
Labels
enhancement New feature or request modules Functionality related to the module block and modules generally

Comments

@radeksimko
Copy link
Member

radeksimko commented Jul 7, 2022

Background

Currently module.calls reports only details about installed modules based on the module manifest.

#987 is expected to change behaviour of that command where it will report modules declared in the configuration instead. version field is also expected to become version constraint, which will match the original (previously wrong) docs: https://github.com/hashicorp/terraform-ls/blob/main/docs/commands.md#modulecalls

Clients would however benefit from having details about both required modules and installed ones.

Also we should continue reporting accurate docs links which point to the particular version of module installed, not the latest version.

Proposal

  • follow the structure of module.providers which already reports both constraints and installed providers
  • introduce v2 of module.calls which will include declared_modules and installed_modules with appropriate details
@radeksimko radeksimko added the enhancement New feature or request label Jul 7, 2022
@xiehan xiehan added the modules Functionality related to the module block and modules generally label Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request modules Functionality related to the module block and modules generally
Projects
None yet
Development

No branches or pull requests

2 participants