Prevent ToTerraformValue panic when the underlying attr.Value types doesn't have type information for its fields
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detro
added
bug
detro
force-pushed
the
detro/bubble_up_incomplete_attrValue_when_calling_ToTerraformValue
branch
from
cfa83da to
0b84b7e
Compare
bflad
approved these changes
May 31, 2022
added 3 commits
May 31, 2022 16:47
…ubble up an error (instead of panic) if the given struct is missing the `ElemType` / `AttrsType` field.
detro
force-pushed
the
detro/bubble_up_incomplete_attrValue_when_calling_ToTerraformValue
branch
from
0b84b7e to
402a4c9
Compare
detro
deleted the
detro/bubble_up_incomplete_attrValue_when_calling_ToTerraformValue
branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToTerraformValuein all the non primitive types ofattr.Value, relies on it containingElemTypeorAttrsTypeto do the conversion to TF types.But if by mistake one omits setting that, the framework was throwing a panic as it wasn't checking for those fields being not null. Now it does.