helper/resource: Always return the error in testStepNewConfig instead of t.Fatalf() so step numbers are included with error messages #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddycarver
approved these changes
Aug 28, 2020
…stead of t.Fatalf() so step numbers are included with error messages Reference: hashicorp#539
paddycarver
force-pushed
the
td-testing-missing-step-numbers
branch
from
5cdce57 to
8775401
Compare
paddycarver
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
Sorry @bflad, merge conflict made me force-push after rebasing on master. Hope you don't mind :( This should be the same change you made, though.
|
@paddycarver all good, thank you for fixing the merge conflict! 😄 |
paddycarver
added a commit
that referenced
this pull request
Sep 3, 2020
paddycarver
added a commit
that referenced
this pull request
Sep 4, 2020
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #539